[UR][SYCL] Add support for `zeCommandListAppendLaunchKernelWithArguments()` #20316

ldorau · 2025-10-08T13:37:50Z

No description provided.

sycl/unittests/Extensions/FreeFunctionCommands/FreeFunctionCommandsEvents.cpp

ldorau · 2025-10-10T19:43:30Z

Rebased

unified-runtime/source/adapters/level_zero/v2/kernel.cpp

…ch in one call." (intel#19661)" This reverts commit d25d6d6. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

…zers

…ts() Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2025-10-29T13:44:25Z

@intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda @intel/llvm-reviewers-runtime @intel/unified-runtime-reviewers-opencl please review

ldorau · 2025-10-29T15:00:22Z

@steffenlarsen Could you review this PR on behalf of @intel/dpcpp-nativecpu-reviewers ?

steffenlarsen

Apologies, I was just granted these powers yesterday. NativeCPU changes LGTM!

github-actions · 2025-10-29T16:09:46Z

@intel/llvm-gatekeepers please consider merging

sycl/source/detail/scheduler/commands.cpp

ldorau · 2025-10-30T07:22:53Z

@intel/llvm-gatekeepers please merge

ldorau · 2025-10-30T07:24:13Z

Apologies, I was just granted these powers yesterday. NativeCPU changes LGTM!

Thank you! :-)

vinser52 · 2025-11-12T17:33:02Z

sycl/source/detail/scheduler/commands.cpp

-  const std::optional<int> &ImplicitLocalArg =
-      DeviceKernelInfo.getImplicitLocalArgPos();
+  std::optional<int> ImplicitLocalArg =
+      ProgramManager::getInstance().kernelImplicitLocalArgPos(


This change introduced perf regression that I am trying to fix in #20621.
@ldorau did you make it intentionally? If yes, could you please clarify the reason?

This change is a part of the 49e4eb2 commit that is a revert of revert of #18764.

I made it by accident during this revert, because it was present on the sycl branch at this time: 24f54ea#diff-654cc430ad3aa564d94299199b9b53ce9cb48b2301edfa8890d6bd509dd23e55L2456-L2458

So it is a mistake made during the revert of a very huge commit.

Fixed by #20621 - thanks @vinser52 for spotting and fixing this issue!

vinser52 · 2025-11-12T17:49:50Z

sycl/source/detail/scheduler/commands.cpp

  }

+  // just a performance optimization - avoid heap allocations
+  static thread_local std::vector<ur_exp_kernel_arg_properties_t> UrArgs;


This line introduce another perf regression. Since we are using TLS here there are a lot of calls to the __tls_get_addr on each call to this function. Actually on each access to the UrArgs.

Originally there was:

std::vector<ur_exp_kernel_arg_properties_t> UrArgs; UrArgs.reserve(Args.size());

24f54ea#diff-654cc430ad3aa564d94299199b9b53ce9cb48b2301edfa8890d6bd509dd23e55R2432-R2433

We have tried to fix it: #20316 (comment) but we have no other idea either...

…er (#20621) The performance regression was introduced in the #20316. We should get the position of the implicit local arg from the deviceKernelInfo, not from the ProgramManager.

ldorau temporarily deployed to WindowsCILock October 8, 2025 13:38 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock October 8, 2025 14:04 — with GitHub Actions Failure

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 816fda9 to f2b4eb5 Compare October 9, 2025 21:13

ldorau had a problem deploying to WindowsCILock October 9, 2025 21:13 — with GitHub Actions Error

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from f2b4eb5 to a766e0e Compare October 9, 2025 21:14

ldorau had a problem deploying to WindowsCILock October 9, 2025 21:14 — with GitHub Actions Error

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from a766e0e to 2e469a3 Compare October 9, 2025 21:31

ldorau temporarily deployed to WindowsCILock October 9, 2025 21:32 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock October 9, 2025 21:58 — with GitHub Actions Inactive

slawekptak reviewed Oct 10, 2025

View reviewed changes

sycl/unittests/Extensions/FreeFunctionCommands/FreeFunctionCommandsEvents.cpp Show resolved Hide resolved

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 2 times, most recently from 896f37c to f10396e Compare October 10, 2025 19:43

ldorau temporarily deployed to WindowsCILock October 10, 2025 19:43 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock October 10, 2025 20:09 — with GitHub Actions Inactive

ldorau requested a review from slawekptak October 10, 2025 20:09

ldorau mentioned this pull request Oct 11, 2025

[TEST CI] Revert Revert "[UR][SYCL] Introduce UR api to set kernel args + laun… (#19661) #20342

Closed

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 4 times, most recently from d3db808 to 1c86d5c Compare October 15, 2025 09:04

ldorau had a problem deploying to WindowsCILock October 15, 2025 09:04 — with GitHub Actions Error

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1c86d5c to 8fafee6 Compare October 15, 2025 09:54

ldorau temporarily deployed to WindowsCILock October 15, 2025 09:54 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock October 15, 2025 10:23 — with GitHub Actions Inactive

ldorau changed the title ~~[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments()~~ [UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() Oct 15, 2025

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 4d5e639 to 1007ca3 Compare October 29, 2025 09:09

ldorau temporarily deployed to WindowsCILock October 29, 2025 09:09 — with GitHub Actions Inactive

kswiecicki reviewed Oct 29, 2025

View reviewed changes

unified-runtime/source/adapters/level_zero/v2/kernel.cpp Outdated Show resolved Hide resolved

unified-runtime/source/adapters/level_zero/v2/kernel.cpp Outdated Show resolved Hide resolved

unified-runtime/source/adapters/level_zero/v2/kernel.cpp Show resolved Hide resolved

ldorau temporarily deployed to WindowsCILock October 29, 2025 09:40 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock October 29, 2025 09:40 — with GitHub Actions Failure

ldorau added 2 commits October 29, 2025 10:09

Revert "Revert "[UR][SYCL] Introduce UR api to set kernel args + laun…

49e4eb2

…ch in one call." (intel#19661)" This reverts commit d25d6d6. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Temporary workaround for urEnqueueKernelLaunchWithArgsExp() in saniti…

7413519

…zers

ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1007ca3 to 467faad Compare October 29, 2025 11:22

ldorau temporarily deployed to WindowsCILock October 29, 2025 11:22 — with GitHub Actions Inactive

ldorau requested review from aelovikov-intel and kswiecicki October 29, 2025 11:29

ldorau temporarily deployed to WindowsCILock October 29, 2025 11:50 — with GitHub Actions Inactive

[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArgumen…

467faad

…ts() Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

kswiecicki approved these changes Oct 29, 2025

View reviewed changes

pbalcer approved these changes Oct 29, 2025

View reviewed changes

aelovikov-intel approved these changes Oct 29, 2025

View reviewed changes

steffenlarsen approved these changes Oct 29, 2025

View reviewed changes

vinser52 reviewed Oct 29, 2025

View reviewed changes

sycl/source/detail/scheduler/commands.cpp Show resolved Hide resolved

kswiecicki merged commit 5df5f45 into intel:sycl Oct 30, 2025
49 of 50 checks passed

ldorau deleted the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch October 30, 2025 10:16

vinser52 mentioned this pull request Nov 12, 2025

Get ImplicitLocalArgPos from DeviceKernelInfo instead of ProgramManager #20621

Merged

vinser52 reviewed Nov 12, 2025

View reviewed changes

[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() #20316

[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() #20316

Uh oh!

Conversation

ldorau commented Oct 8, 2025

Uh oh!

Uh oh!

ldorau commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldorau commented Oct 29, 2025

Uh oh!

ldorau commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Uh oh!

ldorau commented Oct 30, 2025

Uh oh!

ldorau commented Oct 30, 2025

Uh oh!

Uh oh!

vinser52 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ldorau Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldorau Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

vinser52 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ldorau Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

[UR][SYCL] Add support for `zeCommandListAppendLaunchKernelWithArguments()` #20316

[UR][SYCL] Add support for `zeCommandListAppendLaunchKernelWithArguments()` #20316

ldorau commented Oct 29, 2025 •

edited

Loading

ldorau Nov 13, 2025 •

edited

Loading